linux-kernel - Re: [PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1510121132030.6097@nanos>
Date:	Mon, 12 Oct 2015 11:32:56 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Oleksij Rempel <linux@...pel-privat.de>
cc:	linux-kernel@...r.kernel.org, marc.zyngier@....com,
	jason@...edaemon.net
Subject: Re: [PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with
 different offsets

On Mon, 12 Oct 2015, Oleksij Rempel wrote:
> Am 11.10.2015 um 19:58 schrieb Thomas Gleixner:
> >> +	icoll_add_domain(np, ICOLL_NUM_IRQS);
> >>  
> >> -	icoll_domain = irq_domain_add_linear(np, ICOLL_NUM_IRQS,
> >> -					     &icoll_irq_domain_ops, NULL);
> >>  	return icoll_domain ? 0 : -ENODEV;
> > 
> > In case of !icoll_domain this return is not reached as you paniced
> > already. So why would we still check icoll_domain?
> 
> I'm paniced on !icoll_base, icoll_domain will give only warning.
> http://lxr.free-electrons.com/source/kernel/irq/irqdomain.c#L52
> 
> Or do i miss some thing?

Yes. Your patch makes that:

>> +    if (!icoll_domain)
>> +            panic("%s: unable add irq domain", np->full_name);

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/