linux-kernel - Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2015 11:11:51 +0100
From:	Felipe Tonello <eu@...ipetonello.com>
To:	Clemens Ladisch <clemens@...isch.de>
Cc:	Felipe Balbi <balbi@...com>, USB list <linux-usb@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	Peter Chen <Peter.Chen@...escale.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>
Subject: Re: [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done

Hi Balbi,

On Sun, Oct 11, 2015 at 8:08 PM, Clemens Ladisch <clemens@...isch.de> wrote:
> Felipe Balbi wrote:
>> Clemens Ladisch <clemens@...isch.de> writes:
>>> Felipe Tonello wrote:
>>>> req->actual == req->length means that there is no data left to enqueue,
>>>
>>> This condition is not checked in the patch.
>>>
>>>> so free the request.
>>>>
>>>> Signed-off-by: Felipe F. Tonello <eu@...ipetonello.com>
>>>> ---
>>>>  drivers/usb/gadget/function/f_midi.c | 5 ++---
>>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>> diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
>>>> index edb84ca..93212ca 100644
>>>> --- a/drivers/usb/gadget/function/f_midi.c
>>>> +++ b/drivers/usb/gadget/function/f_midi.c
>>>> @@ -256,9 +256,8 @@ f_midi_complete(struct usb_ep *ep, struct usb_request *req)
>>>>                     /* We received stuff. req is queued again, below */
>>>>                     f_midi_handle_out_data(ep, req);
>>>>             } else if (ep == midi->in_ep) {
>>>> -                   /* Our transmit completed. See if there's more to go.
>>>> -                    * f_midi_transmit eats req, don't queue it again. */
>>>> -                   f_midi_transmit(midi, req);
>>>> +                   /* Our transmit completed. Don't queue it again. */
>>>> +                   free_ep_req(ep, req);
>>>>                     return;
>>>>             }
>>>>             break;
>>>
>>> The ALSA framework will give you a notification _once_.  If the
>>> resulting data is larger than midi->buflen, then you have to continue
>>> sending packets.  This is exactly what the call to f_midi_transmit()
>>> does.
>>
>> so, should I drop this series from my TODO queue ?
>
> Yes, this patch needs to be dropped.

You don't need to drop the whole series. Just this patch needs more
work, the rest are fine (including bug fixes).

Felipe Tonello
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/