linux-kernel - Re: [PATCH] xfs: constify sysfs_ops structures

Open Source and information security mailing list archives

Message-ID: <20151012124910.GB25023@bfoster.bfoster>
Date:	Mon, 12 Oct 2015 08:49:10 -0400
From:	Brian Foster <bfoster@...hat.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	Dave Chinner <david@...morbit.com>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	xfs@....sgi.com
Subject: Re: [PATCH] xfs: constify sysfs_ops structures

On Sun, Oct 11, 2015 at 12:42:26PM +0200, Julia Lawall wrote:
> These sysfs_ops structures are never modified.  All other sysfs_ops
> structures in the kernel are declared as const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 

The fix looks correct, but these data structures just happened to be
removed and condensed into a more generic xfs_sysfs_ops definition as
part of the recent per-mount stats series. See commit a27c2640 ("xfs:
consolidate sysfs ops") for reference.

Brian

> ---
>  fs/xfs/xfs_sysfs.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_sysfs.c b/fs/xfs/xfs_sysfs.c
> index aa03670..192c865 100644
> --- a/fs/xfs/xfs_sysfs.c
> +++ b/fs/xfs/xfs_sysfs.c
> @@ -112,7 +112,7 @@ xfs_dbg_store(
>  	return xfs_attr->store ? xfs_attr->store(buf, count, NULL) : 0;
>  }
>  
> -static struct sysfs_ops xfs_dbg_ops = {
> +static const struct sysfs_ops xfs_dbg_ops = {
>  	.show = xfs_dbg_show,
>  	.store = xfs_dbg_store,
>  };
> @@ -227,7 +227,7 @@ xfs_log_store(
>  	return xfs_attr->store ? xfs_attr->store(buf, count, log) : 0;
>  }
>  
> -static struct sysfs_ops xfs_log_ops = {
> +static const struct sysfs_ops xfs_log_ops = {
>  	.show = xfs_log_show,
>  	.store = xfs_log_store,
>  };
> 
> _______________________________________________
> xfs mailing list
> xfs@....sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives