linux-kernel - Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2015 17:26:58 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Markus Pargmann <mpa@...gutronix.de>
Cc:	yalin wang <yalin.wang2010@...il.com>, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap

On Mon, Oct 12, 2015 at 12:48:58PM +0200, Markus Pargmann wrote:
> On Fri, Oct 09, 2015 at 03:51:22PM +0800, yalin wang wrote:

> > +	/* if set, only the cache is modified not the HW */
> > +	bool cache_only;
> > +	/* if set, only the HW is modified not the cache */
> > +	bool cache_bypass;
> > +	/* if set, the cache contains newer data than the HW */
> > +	bool cache_dirty;

> Why are these last three variables just moved and not changed to u8 of
> size 1?

They're exported to debugfs and the relevant debugfs helpers take bool
as an argument (actually I've got a feeling the relevant API is changed
in -next which is likely to be an issue here...).

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)