linux-kernel - Re: [PATCH 2/2] arm: mvebu: reorder nodes under internal-regs by address in RN2120 .dts file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y4f8jbe6.fsf@free-electrons.com>
Date:	Mon, 12 Oct 2015 18:32:17 +0200
From:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	Arnaud Ebalard <arno@...isbad.org>,
	Jason Cooper <jason@...edaemon.net>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, TuxOholic <tuxoholic@...mail.de>
Subject: Re: [PATCH 2/2] arm: mvebu: reorder nodes under internal-regs by address in RN2120 .dts file

Hi Andrew,
 
 On lun., oct. 12 2015, Andrew Lunn <andrew@...n.ch> wrote:

> On Sat, Oct 10, 2015 at 12:10:39AM +0200, Arnaud Ebalard wrote:
>> 
>> This cosmetic patch reorder nodes under internal-regs by increasing
>> address order, as epxected.
>
> expected.
>
> Gregory, can you fix that as you commit?

Done!

>
> Acked-by: Andrew Lunn <andrew@...n.ch>
>
> 	  Andrew
>
>> 
>> Signed-off-by: Arnaud Ebalard <arno@...isbad.org>
>> ---
>>  arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 86 +++++++++++++-------------
>>  1 file changed, 43 insertions(+), 43 deletions(-)
>> 
>> diff --git a/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts b/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
>> index 85b2f87c0b8a..d72a69d97ba2 100644
>> --- a/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
>> +++ b/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
>> @@ -94,54 +94,11 @@
>>  				status = "disabled";
>>  			};
>>  
>> -			/* Two rear eSATA ports */
>> -			sata@...00 {
>> -				nr-ports = <2>;
>> -				status = "okay";
>> -			};
>> -
>> -			serial@...00 {
>> -				status = "okay";
>> -			};
>> -
>> -			mdio {
>> -				phy0: ethernet-phy@0 { /* Marvell 88E1318 */
>> -					reg = <0>;
>> -				};
>> -
>> -				phy1: ethernet-phy@1 { /* Marvell 88E1318 */
>> -					reg = <1>;
>> -				};
>> -			};
>> -
>> -			ethernet@...00 {
>> -				status = "okay";
>> -				phy = <&phy0>;
>> -				phy-mode = "rgmii-id";
>> -			};
>> -
>> -			ethernet@...00 {
>> -				status = "okay";
>> -				phy = <&phy1>;
>> -				phy-mode = "rgmii-id";
>> -			};
>> -
>> -			/* Front USB 2.0 port */
>> -			usb@...00 {
>> -				status = "okay";
>> -			};
>> -
>>  			i2c@...00 {
>>  				compatible = "marvell,mv64xxx-i2c";
>>  				clock-frequency = <400000>;
>>  				status = "okay";
>>  
>> -				isl12057: isl12057@68 {
>> -					compatible = "isil,isl12057";
>> -					reg = <0x68>;
>> -					isil,irq2-can-wakeup-machine;
>> -				};
>> -
>>  				/* Controller for rear fan #1 of 3 (Protechnic
>>  				 * MGT4012XB-O20, 8000RPM) near eSATA port */
>>  				g762_fan1: g762@3e {
>> @@ -178,6 +135,49 @@
>>  					compatible = "gmt,g751";
>>  					reg = <0x4c>;
>>  				};
>> +
>> +				isl12057: isl12057@68 {
>> +					compatible = "isil,isl12057";
>> +					reg = <0x68>;
>> +					isil,irq2-can-wakeup-machine;
>> +				};
>> +			};
>> +
>> +			serial@...00 {
>> +				status = "okay";
>> +			};
>> +
>> +			/* Front USB 2.0 port */
>> +			usb@...00 {
>> +				status = "okay";
>> +			};
>> +
>> +			mdio {
>> +				phy0: ethernet-phy@0 { /* Marvell 88E1318 */
>> +					reg = <0>;
>> +				};
>> +
>> +				phy1: ethernet-phy@1 { /* Marvell 88E1318 */
>> +					reg = <1>;
>> +				};
>> +			};
>> +
>> +			ethernet@...00 {
>> +				status = "okay";
>> +				phy = <&phy0>;
>> +				phy-mode = "rgmii-id";
>> +			};
>> +
>> +			ethernet@...00 {
>> +				status = "okay";
>> +				phy = <&phy1>;
>> +				phy-mode = "rgmii-id";
>> +			};
>> +
>> +			/* Two rear eSATA ports */
>> +			sata@...00 {
>> +				nr-ports = <2>;
>> +				status = "okay";
>>  			};
>>  
>>  			nand@...00 {
>> -- 
>> 2.5.3
>> 

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/