linux-kernel - Re: [PATCH 0/2] staging: comedi: comedidev.h: fix some checkpatch issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151012172551.GA8815@kroah.com>
Date:	Mon, 12 Oct 2015 10:25:51 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Hartley Sweeten <HartleyS@...ionengravers.com>
Cc:	Ian Abbott <abbotti@....co.uk>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] staging: comedi: comedidev.h: fix some checkpatch
 issues

On Mon, Oct 12, 2015 at 05:22:29PM +0000, Hartley Sweeten wrote:
> On Monday, October 12, 2015 10:03 AM, Ian Abbott wrote:
> > Fix some checkpatch issues in "comedidev.h".  There are still some
> > CamelCase warnings, but since those are for the use of "mA" and it
> > represents "milliamps", I think I'll leave them alone.
> >
> > 1) staging: comedi: comedidev.h: add comments to spin-lock and mutex
> > 2) staging: comedi: comedidev.h: spaces preferred around that '*'
> >
> >  drivers/staging/comedi/comedidev.h | 18 +++++++++---------
> >  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> Thanks!
> 
> Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> 
> Ian,
> 
> Just a comment...
> 
> The checkpaatch.pl noise about "mA" defines are a bit annoying but
> I agree that those defines are clearer than "{foo}_milliamps".

I agree, checkpatch is just a "hint", feel free to ignore it when it
says stupid things.  Like this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/