linux-kernel - Re: [PATCH] iio: Move IIO Dummy Driver out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZDanmW90PifFcsTWLEzFNBUK25vDbcR9_iYVCJh3w4FYA@mail.gmail.com>
Date:	Mon, 12 Oct 2015 20:59:57 +0300
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	Cristina Opriceana <cristina.opriceana@...il.com>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Daniel Baluta <daniel.baluta@...el.com>,
	"octavian.purdila@...el.com" <octavian.purdila@...el.com>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: Move IIO Dummy Driver out of staging

<snip>

>> +static unsigned instances = 1;
>> +module_param(instances, uint, 0);

One concern about this. We will still create a default number of 'instances'
when using configuration via configfs?

I'm not sure we can remove this parameter once the module is moved
out of staging, since we break the ABI (?)

The rest looks good to me. I'm pretty sure that moving this out of staging
will make the module more visible and people will jump with enhancements.


thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/