linux-kernel - [PATCH v7 1/3] ARM: irqchip: mxs: do panic if icoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1444677334-12242-2-git-send-email-linux@rempel-privat.de>
Date:	Mon, 12 Oct 2015 21:15:30 +0200
From:	Oleksij Rempel <linux@...pel-privat.de>
To:	linux-kernel@...r.kernel.org, marc.zyngier@....com,
	jason@...edaemon.net, tglx@...utronix.de
Cc:	Oleksij Rempel <linux@...pel-privat.de>
Subject: [PATCH v7 1/3] ARM: irqchip: mxs: do panic if icoll_base == NULL

Current code will only WARN_ON() and dereference the NULL pointer.
In this case it is better to panic and stop execution.

Signed-off-by: Oleksij Rempel <linux@...pel-privat.de>
---
 drivers/irqchip/irq-mxs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c
index 604df63..ce69860 100644
--- a/drivers/irqchip/irq-mxs.c
+++ b/drivers/irqchip/irq-mxs.c
@@ -97,7 +97,8 @@ static int __init icoll_of_init(struct device_node *np,
 			  struct device_node *interrupt_parent)
 {
 	icoll_base = of_iomap(np, 0);
-	WARN_ON(!icoll_base);
+	if (!icoll_base)
+		panic("%s: unable to map resource", np->full_name);
 
 	/*
 	 * Interrupt Collector reset, which initializes the priority
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/