linux-kernel - Re: [RFC] arm: add __initbss section attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151012200422.GA29175@ravnborg.org>
Date:	Mon, 12 Oct 2015 22:04:23 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	yalin wang <yalin.wang2010@...il.com>
Cc:	linux@....linux.org.uk, arnd@...db.de, ard.biesheuvel@...aro.org,
	will.deacon@....com, nico@...aro.org, keescook@...omium.org,
	catalin.marinas@....com, victor.kamensky@...aro.org,
	msalter@...hat.com, vladimir.murzin@....com, ggdavisiv@...il.com,
	paul.gortmaker@...driver.com, mingo@...nel.org,
	rusty@...tcorp.com.au, mcgrof@...e.com, akpm@...ux-foundation.org,
	kirill.shutemov@...ux.intel.com, n-horiguchi@...jp.nec.com,
	aarcange@...hat.com, mhocko@...e.com, jack@...e.cz,
	iamjoonsoo.kim@....com, xiexiuqi@...wei.com, vbabka@...e.cz,
	Vineet.Gupta1@...opsys.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [RFC] arm: add __initbss section attribute

> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
>  
> -#define BSS_SECTION(sbss_align, bss_align, stop_align)			\
> +#define BSS_SECTION(sbss_align, bss_align, initbss_align, stop_align)			\

A few comments:

1) - please align the backslash at the end of the
     line with the backslash above it.
2) - you need to fix all the remaining users of BSS_SECTION.
3) - do we really need the flexibility to specify an alignment (stop_align)?
        If not - drop the extra argument.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/