linux-kernel - Re: randconfig build error with next-20151009, in lib/zlib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2015 14:55:42 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jim Davis <jim.epost@...il.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next <linux-next@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	yalin.wang2010@...il.com
Subject: Re: randconfig build error with next-20151009, in
 lib/zlib_deflate/deftree.c

On Fri, 9 Oct 2015 13:38:25 -0700 Jim Davis <jim.epost@...il.com> wrote:

> Building with the attached random configuration file,
> 
> lib/built-in.o: In function `__bitrev32':
> deftree.c:(.text+0x1e799): undefined reference to `byte_rev_table'
> deftree.c:(.text+0x1e7a0): undefined reference to `byte_rev_table'
> deftree.c:(.text+0x1e7b4): undefined reference to `byte_rev_table'
> deftree.c:(.text+0x1e7c1): undefined reference to `byte_rev_table'

This is really irritating.  We save 287 bytes in kernels which don't
use bitrev.  It isn't worth the hassle, but let's keep plugging.



From: Andrew Morton <akpm@...ux-foundation.org>
Subject: lib/Kconfig: ZLIB_DEFLATE must select BITREVERSE

lib/built-in.o: In function `__bitrev32':
deftree.c:(.text+0x1e799): undefined reference to `byte_rev_table'
deftree.c:(.text+0x1e7a0): undefined reference to `byte_rev_table'
deftree.c:(.text+0x1e7b4): undefined reference to `byte_rev_table'
deftree.c:(.text+0x1e7c1): undefined reference to `byte_rev_table'

Anything which uses bitrevX() has to select BITREVERSE, to grab
lib/bitrev.o.

Reported-by: Jim Davis <jim.epost@...il.com>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 lib/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff -puN lib/Kconfig~lib-kconfig-zlib_deflate-must-select-bitreverse lib/Kconfig
--- a/lib/Kconfig~lib-kconfig-zlib_deflate-must-select-bitreverse
+++ a/lib/Kconfig
@@ -220,6 +220,7 @@ config ZLIB_INFLATE
 
 config ZLIB_DEFLATE
 	tristate
+	select BITREVERSE
 
 config LZO_COMPRESS
 	tristate
_


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/