linux-kernel - Re: [PATCH 13/20] intel-iommu: switch from ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4i=cAT-mmhCbbv_77gdJggXxHk3jRoOg=Qm5H3tsMAK1Q@mail.gmail.com>
Date:	Mon, 12 Oct 2015 15:19:24 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Joerg Roedel <jroedel@...e.de>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-arch@...r.kernel.org, David Woodhouse <dwmw2@...radead.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap

On Mon, Oct 12, 2015 at 3:05 PM, Dan Williams <dan.j.williams@...el.com> wrote:
> On Mon, Oct 12, 2015 at 2:58 PM, Joerg Roedel <jroedel@...e.de> wrote:
>> Hi Dan,
>>
>> On Fri, Oct 09, 2015 at 06:16:46PM -0400, Dan Williams wrote:
>>> In preparation for deprecating ioremap_cache() convert its usage in
>>> intel-iommu to memremap.  This also eliminates the mishandling of the
>>> __iomem annotation in the implementation.
>>
>> I appreciate the change, but in the cover letter you write the API is
>> only implemented for x86 so far? The VT-d driver is also used on ia64,
>> will it still work there with this patch?
>>
>>
>
> I did convert ia64 in the series [1]  but you're right this patch
> can't go in independently of that conversion.  If you ack this one
> I'll carry them in order.
>
> [1]: https://lkml.org/lkml/2015/10/9/702

Ah sorry, got ahead of myself ;-p.  You can safely take this patch
through your tree.  The ia64 patch can happen asynchronously because
kernel/memremap.c has:

__weak void *arch_memremap(resource_size_t offset, size_t size,
unsigned long flags)

...as a temporary fallback until the conversion is complete.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/