linux-kernel - Re: [PATCH] drivers :staging: android: make alignment match open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151013054022.GA20952@kroah.com>
Date:	Mon, 12 Oct 2015 22:40:22 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Liao Tonglang <liaotonglang@...il.com>
Cc:	arve@...roid.com, riandrews@...roid.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers :staging: android: make alignment match open
 parenthesis

On Tue, Oct 13, 2015 at 11:32:31AM +0800, Liao Tonglang wrote:
> Cleanup for checkpatch.pl warn below:
> 	CHECK: Alignment should match open parenthesis
> 	#836: FILE: drivers/staging/android/ashmem.c:836:
> by split three lines to four.
> 
> Signed-off-by: Liao Tonglang <liaotonglang@...il.com>
> ---
>  drivers/staging/android/ashmem.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 60200a3..99fc7dc 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -832,9 +832,10 @@ static int __init ashmem_init(void)
>  {
>  	int ret;
>  
> -	ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
> -					  sizeof(struct ashmem_area),
> -					  0, 0, NULL);
> +	ashmem_area_cachep =
> +		kmem_cache_create("ashmem_area_cache",
> +				  sizeof(struct ashmem_area),
> +				  0, 0, NULL);


Now you are just getting very picky for checkpatch issues, is this
really more readable?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/