linux-kernel - Re: [PATCH v2] thp: use is_zero_pfn only after pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151013062630.GA16146@bbox>
Date:	Tue, 13 Oct 2015 15:26:52 +0900
From:	Minchan Kim <minchan@...nel.org>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	Mel Gorman <mgorman@...e.de>, Vlastimil Babka <vbabka@...e.cz>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Hugh Dickins <hughd@...gle.com>,
	Rik van Riel <riel@...hat.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, stable@...r.kernel.org,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCH v2] thp: use is_zero_pfn only after pte_present check

On Mon, Oct 12, 2015 at 10:41:24PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Oct 13, 2015 at 11:38:38AM +0900, Minchan Kim wrote:
> > Use is_zero_pfn on pteval only after pte_present check on pteval
> > (It might be better idea to introduce is_zero_pte where checks
> > pte_present first). Otherwise, it could work with swap or
> > migration entry and if pte_pfn's result is equal to zero_pfn
> > by chance, we lose user's data in __collapse_huge_page_copy.
> > So if you're luck, the application is segfaulted and finally you
> > could see below message when the application is exit.
> > 
> > BUG: Bad rss-counter state mm:ffff88007f099300 idx:2 val:3
> > 
> > Cc: <stable@...r.kernel.org>
> > Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > Reviewed-by: Andrea Arcangeli <aarcange@...hat.com>
> > Signed-off-by: Minchan Kim <minchan@...nel.org>
> > ---
> > Hello Greg,
> > 
> > This patch should go to -stable but when you will apply it
> > after merging of linus tree, it will be surely conflicted due
> > to userfaultfd part.
> > 
> > I want to know how to handle it.
> 
> You will get an automated email saying it didn't apply and then you
> provide a backported version.  Or you send a properly backported version
> to stable@...r.kernel.org before then, with the git commit id of the
> patch in Linus's tree.

Okay, I will send a right version when I received automatd email.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/