linux-kernel - Re: [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151013091217.0cc0632d@endymion.delvare>
Date:	Tue, 13 Oct 2015 09:12:17 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, ulf.hansson@...aro.org,
	Weijun.Yang@....com, sbranden@...adcom.com,
	t.takinishi@...fujitsu.com, sboyd@...eaurora.org,
	alim.akhtar@...sung.com, ludovic.desroches@...el.com,
	vincent.yang.fujitsu@...il.com, chaotian.jing@...iatek.com,
	linux@...nbow-software.org, yangbo.lu@...escale.com,
	haokexin@...il.com, linux-mmc@...r.kernel.org,
	javier@....samsung.com
Subject: Re: [PATCH] mmc: android-goldfish: Allow compiling the driver with
 COMPILE_TEST

On Sat, 10 Oct 2015 17:08:32 +0100, Luis de Bethencourt wrote:
> The driver depends on GOLDFISH but there isn't a build dependency
> so it's a good idea to allow the driver to always be built when the
> COMPILE_TEST option is enabled.
> 
> That way, the driver can be built with a config generated by make
> allyesconfig and check if a patch would break the build.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
>  drivers/mmc/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 12b274a..56f5b14 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -473,7 +473,7 @@ config MMC_DAVINCI
>  
>  config MMC_GOLDFISH
>  	tristate "goldfish qemu Multimedia Card Interface support"
> -	depends on GOLDFISH
> +	depends on GOLDFISH || COMPILE_TEST
>  	help
>  	  This selects the Goldfish Multimedia card Interface emulation
>  	  found on the Goldfish Android virtual device emulation.

Looks good.

Reviewed-by: Jean Delvare <jdelvare@...e.de>

-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/