linux-kernel - Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <561CBAE7.1070300@samsung.com>
Date:	Tue, 13 Oct 2015 17:03:51 +0900
From:	Ingi Kim <ingi2.kim@...sung.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	sameo@...ux.intel.com, rpurdie@...ys.net, j.anaszewski@...sung.com,
	inki.dae@...sung.com, sw0312.kim@...sung.com,
	beomho.seo@...sung.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

Hi Lee Jones,

Okay, I'm try to remove needless part and resend it
Thanks for the review

Thank you

On 2015년 10월 13일 16:06, Lee Jones wrote:
> On Mon, 12 Oct 2015, Ingi Kim wrote:
> 
>> This patch adds rt5033-led sub device to support it.
>>
>> Signed-off-by: Ingi Kim <ingi2.kim@...sung.com>
>> ---
>>  drivers/mfd/rt5033.c | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
>> index d60f916..b7f374b 100644
>> --- a/drivers/mfd/rt5033.c
>> +++ b/drivers/mfd/rt5033.c
>> @@ -40,13 +40,17 @@ static const struct regmap_irq_chip rt5033_irq_chip = {
>>  };
>>  
>>  static const struct mfd_cell rt5033_devs[] = {
>> -	{ .name = "rt5033-regulator", },
>>  	{
>> +		.name = "rt5033-regulator",
>> +	}, {
> 
> There's no need for this change.  Please remove it.
> 
>>  		.name = "rt5033-charger",
>>  		.of_compatible = "richtek,rt5033-charger",
>>  	}, {
>>  		.name = "rt5033-battery",
>>  		.of_compatible = "richtek,rt5033-battery",
>> +	}, {
>> +		.name = "rt5033-led",
>> +		.of_compatible = "richtek,rt5033-led",
> 
> For when you resubmit with the hunk above removed:
> 
> Acked-by: Lee Jones <lee.jones@...aro.org>
> 
>>  	},
>>  };
>>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/