linux-kernel - Re: [PATCH 4/5] tools: build: fix libiberty feature detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151013110031.GC3628@axis.com>
Date:	Tue, 13 Oct 2015 13:00:32 +0200
From:	Rabin Vincent <rabin.vincent@...s.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] tools: build: fix libiberty feature detection

On Mon, Oct 12, 2015 at 01:35:02PM +0200, Jiri Olsa wrote:
> We have FEATURE_CHECK_CFLAGS/FEATURE_CHECK_LDFLAGS variables
> to pass CFLAGS/LDFLAGS to feature detection build
> 
> Could you also be more specific on what is missing
> to make the libiberty check compile?

We don't need any special CFLAGS/LDFLAGS for libiberty.  What we do need
is any CFLAGS or LDFLAGS set by the user, for example -I or -L to point
to libraries and include files in custom paths.  In all the other
test-*.bin rules in build/feature/Makefile, we use the BUILD macro which
always sends in CFLAGS and LDFLAGS.  The libiberty build line doesn't
use the BUILD macro and thus needs to send in CFLAGS and LDFLAGS
explicitly.

So FEATURE_CHECK_CFLAGS_libiberty doesn't seem like the correct thing to
use, since that would imply that libiberty needs some special flags?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/