linux-kernel - Re: [RFC v2 PATCH 08/14] irq: implement irq_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Oct 2015 19:29:58 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Qais Yousef <qais.yousef@...tec.com>
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, jason@...edaemon.net, marc.zyngier@....com,
	jiang.liu@...ux.intel.com, ralf@...ux-mips.org,
	linux-mips@...ux-mips.org, Qais Yousef <qais.yousef@...tec.com>
Subject: Re: [RFC v2 PATCH 08/14] irq: implement irq_send_ipi

Hi Qais,

[auto build test WARNING on v4.3-rc5 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Qais-Yousef/Implement-generic-IPI-support-mechanism/20151013-182314
config: x86_64-randconfig-s0-10131828 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/smp.h:10,
                    from include/linux/irq.h:12,
                    from kernel/irq/manage.c:12:
   kernel/irq/manage.c: In function '__irq_desc_send_ipi':
   kernel/irq/manage.c:2001:41: error: 'struct irq_data' has no member named 'ipi_mask'
      if (!bitmap_subset(dest->cpumask, data->ipi_mask.cpumask,
                                            ^
   include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                               ^
>> kernel/irq/manage.c:2001:3: note: in expansion of macro 'if'
      if (!bitmap_subset(dest->cpumask, data->ipi_mask.cpumask,
      ^
   kernel/irq/manage.c:2001:41: error: 'struct irq_data' has no member named 'ipi_mask'
      if (!bitmap_subset(dest->cpumask, data->ipi_mask.cpumask,
                                            ^
   include/linux/compiler.h:147:40: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                                           ^
>> kernel/irq/manage.c:2001:3: note: in expansion of macro 'if'
      if (!bitmap_subset(dest->cpumask, data->ipi_mask.cpumask,
      ^
   kernel/irq/manage.c:2001:41: error: 'struct irq_data' has no member named 'ipi_mask'
      if (!bitmap_subset(dest->cpumask, data->ipi_mask.cpumask,
                                            ^
   include/linux/compiler.h:158:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^
>> kernel/irq/manage.c:2001:3: note: in expansion of macro 'if'
      if (!bitmap_subset(dest->cpumask, data->ipi_mask.cpumask,
      ^

vim +/if +2001 kernel/irq/manage.c

  1985	}
  1986	
  1987	int __irq_desc_send_ipi(struct irq_desc *desc, const struct ipi_mask *dest)
  1988	{
  1989		struct irq_data *data = irq_desc_get_irq_data(desc);
  1990		struct irq_chip *chip = irq_data_get_irq_chip(data);
  1991	
  1992		if (!chip || !chip->irq_send_ipi)
  1993			return -EINVAL;
  1994	
  1995		/*
  1996		 * Do not validate the mask for IPIs marked global. These are
  1997		 * regular IPIs so we can avoid the operation as their target
  1998		 * mask is the cpu_possible_mask.
  1999		 */
  2000		if (!dest->global) {
> 2001			if (!bitmap_subset(dest->cpumask, data->ipi_mask.cpumask,
  2002					   dest->nbits))
  2003				return -EINVAL;
  2004		}
  2005	
  2006		chip->irq_send_ipi(data, dest);
  2007		return 0;
  2008	}
  2009	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (22902 bytes)