linux-kernel - Re: [PATCH v3 12/13] scsi: ufs-exynos: add UFS host support for Exynos SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <561CEEE3.7060401@samsung.com>
Date:	Tue, 13 Oct 2015 17:15:39 +0530
From:	Alim Akhtar <alim.akhtar@...sung.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	JBottomley@...n.com, vinholikatti@...il.com,
	amit.daniel@...sung.com, essuuj@...il.com,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v3 12/13] scsi: ufs-exynos: add UFS host support for Exynos
 SoCs



On 10/13/2015 05:08 PM, Arnd Bergmann wrote:
> On Tuesday 13 October 2015 16:49:39 Alim Akhtar wrote:
>>>> diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h
>>>> new file mode 100644
>>>> index 0000000..58aa714
>>>> --- /dev/null
>>>> +++ b/drivers/scsi/ufs/ufs-exynos.h
>>>> @@ -0,0 +1,463 @@
>>>> +/*
>>>> + * UFS Host Controller driver for Exynos specific extensions
>>>> + *
>>>> + * Copyright (C) 2014-2015 Samsung Electronics Co., Ltd.
>>>> + *
>>>> + * This program is free software; you can redistribute it and/or modify
>>>> + * it under the terms of the GNU General Public License as published by
>>>> + * the Free Software Foundation; either version 2 of the License, or
>>>> + * (at your option) any later version.
>>>> + */
>>>> +
>>>> +#ifndef _UFS_EXYNOS_H_
>>>> +#define _UFS_EXYNOS_H_
>>>
>>> You have a lot of things in this header that are only used in one of the
>>> .c files, so just move them there and make the header as small as possible.
>>>
>> hmm..these are mostly the registers defines, will removes the one which
>> are not being used as of now.
>> Do you think I should sill move them to .c file?
>>
>
> Yes. No need to remove the unused register definitions, just don't put
> them into a separate header if they are only used in one place.
>
Ok will do that in v4.
Thanks.
> 	Arnd
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/