linux-kernel - Re: [PATCH v2] HID: hiddev: change hiddev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPcq8BuVENk=eDAyxyAnRy4YUZy8ibrXxgGb3RZzk55AZg@mail.gmail.com>
Date:	Tue, 13 Oct 2015 10:49:49 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, jikos@...nel.org,
	linux-usb@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v2] HID: hiddev: change hiddev_connect() to return bool

2015-10-09 22:00 GMT+09:00 Luis de Bethencourt <luisbg@....samsung.com>:
> Since hid_connect() only cares about hiddev_connect() succeeding or
> failing, there is no need for this function to return an int and it can
> return a bool instead.

It can return bool but it would not be in line with kernel coding
style. The hiddev_connect() I believe is an action, so "the function
should return an error-code integer.".

Best regards,
Krzysztof

>
> Suggested-by: Jiri Kosina <jikos@...nel.org>
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
>
> Hi,
>
> No idea why my local build did not complain about the obvious mistake
> on the previous version of the patch.
>
> Sorry about that,
> Luis
>
>  drivers/hid/hid-core.c      |  2 +-
>  drivers/hid/usbhid/hiddev.c | 10 +++++-----
>  include/linux/hid.h         |  2 +-
>  include/linux/hiddev.h      |  2 +-
>  4 files changed, 8 insertions(+), 8 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/