linux-kernel - Re: [PATCH] signal: Make the si_code check in rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+y5pbTGC-yuX_UoGPLuU6NiDeNdqH419nU3G-qvjMOL7wbvsA@mail.gmail.com>
Date:	Tue, 13 Oct 2015 16:40:45 +0100
From:	"Amanieu d'Antras" <amanieu@...il.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH] signal: Make the si_code check in rt_[tg]sigqueueinfo stricter

On Tue, Oct 13, 2015 at 3:54 PM, Oleg Nesterov <oleg@...hat.com> wrote:
> I agree, this doesn't look right... But I'm afraid it is too late to
> change this, this logic predates the git history.
>
> And unless I missed something copy_siginfo_to_user32() assumes that
> "from" was filled by copy_siginfo_from_user32(), but this is not true
> if the sender is 64bit task. And this all doesn't match the behaviour
> with 32bit kernel.
>
> Personally, I think we should leave this ancient code alone. But I
> agree that something like below looks right... I dunno.

I am currently working on another patch set that updates
copy_siginfo_{to,from}_user32 to match the behavior of 32-bit kernels.
I will fix the si_code encoding there with a change similar to yours.

Amanieu d'Antras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/