linux-kernel - [PATCH] Drivers: hv: vss: run only on supported host versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1444760511-4357-1-git-send-email-olaf@aepfle.de>
Date:	Tue, 13 Oct 2015 18:21:51 +0000
From:	Olaf Hering <olaf@...fle.de>
To:	kys@...rosoft.com, haiyangz@...rosoft.com,
	gregkh@...uxfoundation.org
Cc:	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	Olaf Hering <olaf@...fle.de>
Subject: [PATCH] Drivers: hv: vss: run only on supported host versions

The Backup integration service on WS2012 has appearently trouble to
negotiate with a guest which does not support the provided util version.
Currently the VSS driver supports only version 5/0. A WS2012 offers only
version 1/x and 3/x, and vmbus_prep_negotiate_resp correctly returns an
empty icframe_vercnt/icmsg_vercnt. But the host ignores that and
continues to send ICMSGTYPE_NEGOTIATE messages. The result are weird
errors during boot and general misbehaviour.

Check the Windows version to work around the host bug, skip hv_vss_init
on WS2012 and older.

Signed-off-by: Olaf Hering <olaf@...fle.de>
---
 drivers/hv/hv_snapshot.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_snapshot.c
index a548ae4..52f10ed 100644
--- a/drivers/hv/hv_snapshot.c
+++ b/drivers/hv/hv_snapshot.c
@@ -331,6 +331,16 @@ static void vss_on_reset(void)
 int
 hv_vss_init(struct hv_util_service *srv)
 {
+	switch (vmbus_proto_version) {
+		case VERSION_WS2008:
+		case VERSION_WIN7:
+		case VERSION_WIN8:
+			pr_warn("Integration service 'Backup (volume snapshot)'"
+				" not supported on this host version.\n");
+			return -ENOTSUPP;
+		default:
+			break;
+	}
 	recv_buffer = srv->recv_buffer;
 
 	/*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/