linux-kernel - RE: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02E7334B1630744CBDC55DA8586225834A6F8C6B@ORSMSX102.amr.corp.intel.com>
Date:	Tue, 13 Oct 2015 18:33:23 +0000
From:	"Yang, Fei" <fei.yang@...el.com>
To:	Lee Jones <lee.jones@...aro.org>,
	Borun Fu <borun.fu@...ux.intel.com>
CC:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>,
	"jacob.jun.pan@...ux.intel.com" <jacob.jun.pan@...ux.intel.com>
Subject: RE: [PATCH] mfd: axp20x: Add a cell for the power button part of
 the,axp288 PMICs

>>  static struct resource axp288_fuel_gauge_resources[] = {
>>  	{
>>  		.start = AXP288_IRQ_QWBTU,
>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>>  		.resources = axp288_fuel_gauge_resources,
>>  	},
>>  	{
>> +		.name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
>
>Doesn't this change insinuate that?
>
>If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right? 
>

Are you suggesting to remove the comment? Just want to make sure I understand you correctly.

>> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
>> +		.resources = axp288_power_button_resources,
>> +	},
>> +	{
>>  		.name = "axp288_pmic_acpi",
>>  	},
>>  };

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog