| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <561D50EC.8010305@gmail.com> Date: Tue, 13 Oct 2015 11:43:56 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Vivien Didelot <vivien.didelot@...oirfairelinux.com> CC: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com, "David S. Miller" <davem@...emloft.net>, Scott Feldman <sfeldma@...il.com>, Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch> Subject: Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code On 13/10/15 11:11, Vivien Didelot wrote: > On Oct. Tuesday 13 (42) 10:35 AM, Florian Fainelli wrote: >> On 13/10/15 09:46, Vivien Didelot wrote: >>> There is no need to write the MAC address before every Get Next >>> operation, since ATU MAC registers are not cleared between calls. >>> >>> Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext >>> so future code could call ATU Get Next multiple times and save a few >>> register access. >> >> Missing SoB tag here. > > Damn, good catch. Can I add it in reply to the patch, or should I send a > v3? I am fairly positive patchwork should be able to pick it up, so replying to your patch might just do it fine. -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists