linux-kernel - Re: [PATCH] regulator: core: avoid unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6859029.WgxSIWq5Yi@wuerfel>
Date:	Tue, 13 Oct 2015 21:28:13 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Mark Brown <broonie@...nel.org>
Cc:	Sascha Hauer <s.hauer@...gutronix.de>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] regulator: core: avoid unused variable warning

On Monday 12 October 2015 16:42:31 Mark Brown wrote:
> On Fri, Oct 09, 2015 at 02:36:47PM +0200, Arnd Bergmann wrote:
> 
> > The second argument of the mutex_lock_nested() helper is only
> > evaluated if CONFIG_DEBUG_LOCK_ALLOC is set. Otherwise we
> > get this build warning for the new regulator_lock_supply
> > function:
> 
> Shouldn't we have an annotation or something for this in
> mutex_lock_nested()?  It seems like something that might come up
> elsewhere and it's a bit of a surprise to have one of the arguments
> there not be evaluated.
> 

I've found a better solution by making mutex_lock_nested an
inline function. Will send a new patch.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/