lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Oct 2015 20:48:42 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: Dmitry Safonov <0x7f454c46@...il.com> Cc: mingo@...hat.com, corbet@....net, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/5] ftrace: remove redundant strsep in mod_callback On Tue, 29 Sep 2015 19:46:12 +0300 Dmitry Safonov <0x7f454c46@...il.com> wrote: > - ret = ftrace_match_module_records(hash, func, mod); > - if (!ret) > - ret = -EINVAL; > + ret = ftrace_match_module_records(hash, func, param); > + if (ret == 0) Small nit, personally, I prefer the if (!ret) version. For me "== 0" is for counters and strcmp. I may change this to be consistent with the rest of the code. -- Steve > + return -EINVAL; > if (ret < 0) > return ret; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists