linux-kernel - Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151014232927.4b43a897@free-electrons.com>
Date:	Wed, 14 Oct 2015 23:29:27 +0200
From:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Viresh Kumar <viresh.kumar@...aro.org>,
	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tawfik Bayouk <tawfik@...vell.com>,
	Nadav Haklai <nadavh@...vell.com>,
	Lior Amsalem <alior@...vell.com>,
	Gregory Clement <gregory.clement@...e-electrons.com>
Subject: Re: [PATCH] PM / OPP: Remove confusing error message in
 of_cpumask_init_opp_table()

Hello,

On Wed, 14 Oct 2015 23:44:03 +0200, Rafael J. Wysocki wrote:
> On Wednesday, October 14, 2015 11:10:39 PM Thomas Petazzoni wrote:
> > Rafael,
> > 
> > On Wed, 14 Oct 2015 23:28:51 +0200, Rafael J. Wysocki wrote:
> > 
> > > > To avoid this confusion, this patch simply deletes the error message.
> > > > 
> > > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> > > 
> > > That's only present in linux-next now, right?
> > 
> > No, it is already in 4.3-rc since 4.3-rc1. The commit adding the
> > problematic function is 8d4d4e98acd68c31435ebb7beea591dbf60b9eb2, and
> > this function gets used in cpufreq-dt starting at commit
> > 2e02d8723edf6599988852a8ade8f83b2f766cb8.
> > 
> > $ git tag --contains 2e02d8723edf6599988852a8ade8f83b2f766cb8
> > v4.3-rc1
> > v4.3-rc2
> > v4.3-rc3
> > v4.3-rc4
> > v4.3-rc5
> 
> OK, thanks!
> 
> It should carry a
> 
> Fixes: 2e02d8723edf
> 
> tag then, right?

Yes, I wasn't sure if it really is a fix, and if so, which commit it is
fixing. It is really 8d4d4e98acd68c31435ebb7beea591dbf60b9eb2 that
introduces the confusing message, but the message will not appear until
the newly added function gets used in
2e02d8723edf6599988852a8ade8f83b2f766cb8.

But if 2e02d8723edf6599988852a8ade8f83b2f766cb8 is considered to be the
commit actually introducing the regression, then I'll resubmit an
updated version with the Fixes: tag.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/