[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <561ECA86.2050100@roeck-us.net>
Date: Wed, 14 Oct 2015 14:35:02 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Luis de Bethencourt <luisbg@....samsung.com>,
linux-kernel@...r.kernel.org
Cc: linux-watchdog@...r.kernel.org, wim@...ana.be,
javier@....samsung.com
Subject: Re: [PATCH v2] watchdog: Compile possible drivers with COMPILE_TEST
On 10/14/2015 11:55 AM, Luis de Bethencourt wrote:
> These drivers have depends that aren't build dependencies, so it's
> a good idea to allow these drivers to always be built when the
> COMPILE_TEST option is enabled.
>
> That way, the drivers can be built with a config generated by make
> allyesconfig and check if a patch would break the build.
>
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
What architectures have you actually tested this for ?
Guenter
> ---
>
> Hi,
>
> I have removed the COMPILE_TEST for SIRFSOC_WATCHDOG, since the kbuild test
> robot complained with warnings about it.
>
> Thanks,
> Luis
>
> drivers/watchdog/Kconfig | 46 +++++++++++++++++++++++-----------------------
> 1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 79e1aa1..b3d69c3 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -190,7 +190,7 @@ config AT91SAM9X_WATCHDOG
>
> config SAMA5D4_WATCHDOG
> tristate "Atmel SAMA5D4 Watchdog Timer"
> - depends on ARCH_AT91
> + depends on ARCH_AT91 || COMPILE_TEST
> select WATCHDOG_CORE
> help
> Atmel SAMA5D4 watchdog timer is embedded into SAMA5D4 chips.
> @@ -261,7 +261,7 @@ config HAVE_S3C2410_WATCHDOG
>
> config S3C2410_WATCHDOG
> tristate "S3C2410 Watchdog"
> - depends on HAVE_S3C2410_WATCHDOG
> + depends on HAVE_S3C2410_WATCHDOG || COMPILE_TEST
> select WATCHDOG_CORE
> select MFD_SYSCON if ARCH_EXYNOS5
> help
> @@ -299,7 +299,7 @@ config DW_WATCHDOG
>
> config EP93XX_WATCHDOG
> tristate "EP93xx Watchdog"
> - depends on ARCH_EP93XX
> + depends on ARCH_EP93XX || COMPILE_TEST
> select WATCHDOG_CORE
> help
> Say Y here if to include support for the watchdog timer
> @@ -310,7 +310,7 @@ config EP93XX_WATCHDOG
>
> config OMAP_WATCHDOG
> tristate "OMAP Watchdog"
> - depends on ARCH_OMAP16XX || ARCH_OMAP2PLUS
> + depends on ARCH_OMAP16XX || ARCH_OMAP2PLUS || COMPILE_TEST
> select WATCHDOG_CORE
> help
> Support for TI OMAP1610/OMAP1710/OMAP2420/OMAP3430/OMAP4430 watchdog. Say 'Y'
> @@ -346,7 +346,7 @@ config IOP_WATCHDOG
>
> config DAVINCI_WATCHDOG
> tristate "DaVinci watchdog"
> - depends on ARCH_DAVINCI || ARCH_KEYSTONE
> + depends on ARCH_DAVINCI || ARCH_KEYSTONE || COMPILE_TEST
> select WATCHDOG_CORE
> help
> Say Y here if to include support for the watchdog timer
> @@ -380,7 +380,7 @@ config RN5T618_WATCHDOG
>
> config SUNXI_WATCHDOG
> tristate "Allwinner SoCs watchdog support"
> - depends on ARCH_SUNXI
> + depends on ARCH_SUNXI || COMPILE_TEST
> select WATCHDOG_CORE
> help
> Say Y here to include support for the watchdog timer
> @@ -409,7 +409,7 @@ config TWL4030_WATCHDOG
>
> config STMP3XXX_RTC_WATCHDOG
> tristate "Freescale STMP3XXX & i.MX23/28 watchdog"
> - depends on RTC_DRV_STMP
> + depends on RTC_DRV_STMP || COMPILE_TEST
> select WATCHDOG_CORE
> help
> Say Y here to include support for the watchdog timer inside
> @@ -419,7 +419,7 @@ config STMP3XXX_RTC_WATCHDOG
>
> config NUC900_WATCHDOG
> tristate "Nuvoton NUC900 watchdog"
> - depends on ARCH_W90X900
> + depends on ARCH_W90X900 || COMPILE_TEST
> help
> Say Y here if to include support for the watchdog timer
> for the Nuvoton NUC900 series SoCs.
> @@ -428,7 +428,7 @@ config NUC900_WATCHDOG
>
> config TS72XX_WATCHDOG
> tristate "TS-72XX SBC Watchdog"
> - depends on MACH_TS72XX
> + depends on MACH_TS72XX || COMPILE_TEST
> help
> Technologic Systems TS-7200, TS-7250 and TS-7260 boards have
> watchdog timer implemented in a external CPLD chip. Say Y here
> @@ -446,7 +446,7 @@ config MAX63XX_WATCHDOG
>
> config IMX2_WDT
> tristate "IMX2+ Watchdog"
> - depends on ARCH_MXC
> + depends on ARCH_MXC || COMPILE_TEST
> select REGMAP_MMIO
> select WATCHDOG_CORE
> help
> @@ -484,7 +484,7 @@ config RETU_WATCHDOG
>
> config MOXART_WDT
> tristate "MOXART watchdog"
> - depends on ARCH_MOXART
> + depends on ARCH_MOXART || COMPILE_TEST
> help
> Say Y here to include Watchdog timer support for the watchdog
> existing on the MOXA ART SoC series platforms.
> @@ -503,7 +503,7 @@ config SIRFSOC_WATCHDOG
>
> config ST_LPC_WATCHDOG
> tristate "STMicroelectronics LPC Watchdog"
> - depends on ARCH_STI
> + depends on ARCH_STI || COMPILE_TEST
> depends on OF
> select WATCHDOG_CORE
> help
> @@ -539,7 +539,7 @@ config QCOM_WDT
>
> config MESON_WATCHDOG
> tristate "Amlogic Meson SoCs watchdog support"
> - depends on ARCH_MESON
> + depends on ARCH_MESON || COMPILE_TEST
> select WATCHDOG_CORE
> help
> Say Y here to include support for the watchdog timer
> @@ -549,7 +549,7 @@ config MESON_WATCHDOG
>
> config MEDIATEK_WATCHDOG
> tristate "Mediatek SoCs watchdog support"
> - depends on ARCH_MEDIATEK
> + depends on ARCH_MEDIATEK || COMPILE_TEST
> select WATCHDOG_CORE
> help
> Say Y here to include support for the watchdog timer
> @@ -559,7 +559,7 @@ config MEDIATEK_WATCHDOG
>
> config DIGICOLOR_WATCHDOG
> tristate "Conexant Digicolor SoCs watchdog support"
> - depends on ARCH_DIGICOLOR
> + depends on ARCH_DIGICOLOR || COMPILE_TEST
> select WATCHDOG_CORE
> help
> Say Y here to include support for the watchdog timer
> @@ -582,7 +582,7 @@ config LPC18XX_WATCHDOG
>
> config AT32AP700X_WDT
> tristate "AT32AP700x watchdog"
> - depends on CPU_AT32AP700X
> + depends on CPU_AT32AP700X || COMPILE_TEST
> help
> Watchdog timer embedded into AT32AP700x devices. This will reboot
> your system when the timeout is reached.
> @@ -690,7 +690,7 @@ config GEODE_WDT
>
> config SC520_WDT
> tristate "AMD Elan SC520 processor Watchdog"
> - depends on MELAN
> + depends on MELAN || COMPILE_TEST
> help
> This is the driver for the hardware watchdog built in to the
> AMD "Elan" SC520 microcomputer commonly used in embedded systems.
> @@ -963,7 +963,7 @@ config NV_TCO
>
> config RDC321X_WDT
> tristate "RDC R-321x SoC watchdog"
> - depends on X86_RDC321X
> + depends on X86_RDC321X || COMPILE_TEST
> help
> This is the driver for the built in hardware watchdog
> in the RDC R-321x SoC.
> @@ -987,7 +987,7 @@ config 60XX_WDT
>
> config SBC8360_WDT
> tristate "SBC8360 Watchdog Timer"
> - depends on X86_32
> + depends on X86_32 || COMPILE_TEST
> ---help---
>
> This is the driver for the hardware watchdog on the SBC8360 Single
> @@ -1178,7 +1178,7 @@ config ATH79_WDT
>
> config BCM47XX_WDT
> tristate "Broadcom BCM47xx Watchdog Timer"
> - depends on BCM47XX || ARCH_BCM_5301X
> + depends on BCM47XX || ARCH_BCM_5301X || COMPILE_TEST
> select WATCHDOG_CORE
> help
> Hardware driver for the Broadcom BCM47xx Watchdog Timer.
> @@ -1293,7 +1293,7 @@ config BCM2835_WDT
>
> config BCM_KONA_WDT
> tristate "BCM Kona Watchdog"
> - depends on ARCH_BCM_MOBILE
> + depends on ARCH_BCM_MOBILE || COMPILE_TEST
> select WATCHDOG_CORE
> help
> Support for the watchdog timer on the following Broadcom BCM281xx
> @@ -1368,7 +1368,7 @@ config 8xxx_WDT
>
> config MV64X60_WDT
> tristate "MV64X60 (Marvell Discovery) Watchdog Timer"
> - depends on MV64X60
> + depends on MV64X60 || COMPILE_TEST
>
> config PIKA_WDT
> tristate "PIKA FPGA Watchdog"
> @@ -1533,7 +1533,7 @@ config PCWATCHDOG
>
> config MIXCOMWD
> tristate "Mixcom Watchdog"
> - depends on ISA
> + depends on ISA || COMPILE_TEST
> ---help---
> This is a driver for the Mixcom hardware watchdog cards. This
> watchdog simply watches your kernel to make sure it doesn't freeze,
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists