linux-kernel - Re: [PATCH 2/2] Fixed Trivial Warnings in file: Deleted Spaces prior to tabs, and added lines. modified: kernel/auditfilter.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10476084.rIoW7K08e6@sifl>
Date:	Wed, 14 Oct 2015 17:54:08 -0400
From:	Paul Moore <paul@...l-moore.com>
To:	Scott Matheina <scott@...heina.com>
Cc:	eparis@...hat.com, linux-audit@...hat.com,
	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH 2/2] Fixed Trivial Warnings in file:  Deleted Spaces prior to tabs, and added lines. modified:   kernel/auditfilter.c

On Saturday, October 10, 2015 08:57:55 PM Scott Matheina wrote:
> Signed-off-by: Scott Matheina <scott@...heina.com>
> ---
>  kernel/auditfilter.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)

Sorry for the delay in reviewing this, comments inline ...

> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> index 7714d93..774f9ad 100644
> --- a/kernel/auditfilter.c
> +++ b/kernel/auditfilter.c
> @@ -39,13 +39,13 @@
>   * Locking model:
>   *
>   * audit_filter_mutex:
> - * 		Synchronizes writes and blocking reads of audit's filterlist
> - * 		data.  Rcu is used to traverse the filterlist and access
> - * 		contents of structs audit_entry, audit_watch and opaque
> - * 		LSM rules during filtering.  If modified, these structures
> - * 		must be copied and replace their counterparts in the filterlist.
> - * 		An audit_parent struct is not accessed during filtering, so may
> - * 		be written directly provided audit_filter_mutex is held.
> + *		Synchronizes writes and blocking reads of audit's filterlist
> + *		data.  Rcu is used to traverse the filterlist and access
> + *		contents of structs audit_entry, audit_watch and opaque
> + *		LSM rules during filtering.  If modified, these structures
> + *		must be copied and replace their counterparts in the filterlist.
> + *		An audit_parent struct is not accessed during filtering, so may
> + *		be written directly provided audit_filter_mutex is held.
>   */

Okay, that's fine.

>  /* Audit filter lists, defined in <linux/audit.h> */
> @@ -109,6 +109,7 @@ void audit_free_rule_rcu(struct rcu_head *head)
>  {
>  	struct audit_entry *e = container_of(head, struct audit_entry, rcu);
>  	audit_free_rule(e);
> +
>  }

Why?

>  /* Initialize an audit filterlist entry. */
> @@ -176,9 +177,11 @@ static __u32 *classes[AUDIT_SYSCALL_CLASSES];
>  int __init audit_register_class(int class, unsigned *list)
>  {
>  	__u32 *p = kcalloc(AUDIT_BITMASK_SIZE, sizeof(__u32), GFP_KERNEL);
> +
>  	if (!p)
>  		return -ENOMEM;

Okay.

>  	while (*list != ~0U) {
> +
>  		unsigned n = *list++;
>  		if (n >= AUDIT_BITMASK_SIZE * 32 - AUDIT_SYSCALL_CLASSES) {
>  			kfree(p);

Why?

-- 
paul moore
www.paul-moore.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/