linux-kernel - Re: [PATCH 04/20] x86: Rewrite copy_siginfo_{to,from}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Oct 2015 06:47:36 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Amanieu d'Antras <amanieu@...il.com>
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org,
	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, x86@...nel.org,
	Brian Gerst <brgerst@...il.com>,
	Amanieu d'Antras <amanieu@...il.com>
Subject: Re: [PATCH 04/20] x86: Rewrite copy_siginfo_{to,from}_user32

Hi Amanieu,

[auto build test WARNING on arm64/for-next/core -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Amanieu-d-Antras/Fix-handling-of-compat_siginfo_t/20151015-051137
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> arch/x86/kernel/signal_compat.c:158:30: sparse: Using plain integer as NULL pointer
   arch/x86/kernel/signal_compat.c:197:30: sparse: Using plain integer as NULL pointer

vim +158 arch/x86/kernel/signal_compat.c

   142			err |= __copy_from_user(to->_sifields._pad, from->_sifields._pad, SI_PAD_SIZE * sizeof(int))
   143				? -EFAULT : 0;
   144			return err;
   145		}
   146		switch (to->si_code & __SI_MASK) {
   147		case __SI_KILL:
   148			err |= __get_user(to->si_pid, &from->si_pid);
   149			err |= __get_user(to->si_uid, &from->si_uid);
   150			break;
   151		case __SI_TIMER:
   152			err |= __get_user(to->si_tid, &from->si_tid);
   153			err |= __get_user(to->si_overrun, &from->si_overrun);
   154			/*
   155			 * Put the sigval in si_int, which matches the convention
   156			 * used in get_compat_sigevent.
   157			 */
 > 158			to->si_ptr = 0; /* Avoid uninitialized bits in the union */
   159			err |= __get_user(to->si_int, &from->si_int);
   160			break;
   161		case __SI_POLL:
   162			err |= __get_user(to->si_band, &from->si_band);
   163			err |= __get_user(to->si_fd, &from->si_fd);
   164			break;
   165		case __SI_FAULT:
   166			err |= __get_user(ptr32, &from->si_addr);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/