linux-kernel - Re: [PATCH] input: cyapa: fix the copy paste error on electrodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151014063420.GF20406@dtor-ws>
Date:	Tue, 13 Oct 2015 23:34:20 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Dudley Du <dudl@...ress.com>
Cc:	bleung@...gle.com, sudipm.mukherjee@...il.com,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: cyapa: fix the copy paste error on electrodes_rx
 value

On Mon, Oct 12, 2015 at 02:17:04PM +0800, Dudley Du wrote:
> Fix the copy paste error on the electrodes_rx value set code which will
> cause the electrodes_rx value be always set to the value of electrodes_y.
> 
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Reviewed-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> Signed-off-by: Dudley Du <dudl@...ress.com>

Applied (with change to ternary ?: ), thank you.

> ---
>  drivers/input/mouse/cyapa_gen6.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/input/mouse/cyapa_gen6.c b/drivers/input/mouse/cyapa_gen6.c
> index 5f19107..a5eb5ae 100644
> --- a/drivers/input/mouse/cyapa_gen6.c
> +++ b/drivers/input/mouse/cyapa_gen6.c
> @@ -241,14 +241,12 @@ static int cyapa_gen6_read_sys_info(struct cyapa *cyapa)
>  	memcpy(&cyapa->product_id[13], &resp_data[62], 2);
>  	cyapa->product_id[15] = '\0';
>  
> +	/* Get the number of Rx electrodes. */
>  	rotat_align = resp_data[68];
> -	if (rotat_align) {
> +	if (rotat_align)
>  		cyapa->electrodes_rx = cyapa->electrodes_y;
> -		cyapa->electrodes_rx = cyapa->electrodes_y;
> -	} else {
> +	else
>  		cyapa->electrodes_rx = cyapa->electrodes_x;
> -		cyapa->electrodes_rx = cyapa->electrodes_y;
> -	}
>  	cyapa->aligned_electrodes_rx = (cyapa->electrodes_rx + 3) & ~3u;
>  
>  	if (!cyapa->electrodes_x || !cyapa->electrodes_y ||
> -- 
> 1.9.1
> 
> 
> ---------------------------------------------------------------
> This message and any attachments may contain Cypress (or its
> subsidiaries) confidential information. If it has been received
> in error, please advise the sender and immediately delete this
> message.
> ---------------------------------------------------------------
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/