[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 14 Oct 2015 09:07:49 +0800
From: Daniel Kurtz <djkurtz@...omium.org>
To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc: Bayi Cheng <bayi.cheng@...iatek.com>,
David Woodhouse <dwmw2@...radead.org>,
Brian Norris <computersforpeace@...il.com>,
Mark Rutland <mark.rutland@....com>,
"open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>,
srv_heupstream <srv_heupstream@...iatek.com>,
Pawel Moll <pawel.moll@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Sascha Hauer <s.hauer@...gutronix.de>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Rob Herring <robh+dt@...nel.org>,
linux-mediatek@...ts.infradead.org,
Kumar Gala <galak@...eaurora.org>,
Matthias Brugger <matthias.bgg@...il.com>,
linux-mtd@...ts.infradead.org,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 3/3] arm64: dts: mt8173: Add nor flash node
Sergei,
On Tue, Oct 13, 2015 at 10:33 PM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Hello.
>
> On 10/13/2015 12:39 PM, Bayi Cheng wrote:
>
>> Add Mediatek nor flash node
>>
>> Signed-off-by: Bayi Cheng <bayi.cheng@...iatek.com>
>> ---
>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> index d18ee42..385c2e4 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> @@ -365,6 +365,21 @@
>> status = "disabled";
>> };
>>
>> + nor_flash: spi@...0d000 {
>
>
> I don't think this is a good label name for a SPI controller.
You think "spi" is not a good name for SPI controller?
Or you mean the label "nor_flash"?
Would you prefer:
spi_nor_flash: spi@...0d000
>
>> + compatible = "mediatek,mt8173-nor";
>> + reg = <0 0x1100d000 0 0xe0>;
>> + clocks = <&pericfg CLK_PERI_SPI>,
>> + <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
>> + clock-names = "spi", "sf";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + flash@0 {
>> + compatible = "jedec,spi-nor";
>> + reg = <0>;
>> + };
>> + };
>> +
>> i2c3: i2c3@...10000 {
>
>
> Grr, the name should be "i2c@...10000".
Don't worry. This is already fixed in Matthias' tree:
https://github.com/mbgg/linux-mediatek/commit/1ee35c05d9c67771d649f687e6f76e61e76eb779
-Dan
>
> [...]
>
> MBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists