linux-kernel - Re: [PATCH] soc: qcom: smd-rpm: Correct the active vs sleep state flagging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <561E03C4.5040203@linaro.org>
Date:	Wed, 14 Oct 2015 10:27:00 +0300
From:	Georgi Djakov <georgi.djakov@...aro.org>
To:	Bjorn Andersson <bjorn.andersson@...ymobile.com>,
	Andy Gross <agross@...eaurora.org>
Cc:	linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: smd-rpm: Correct the active vs sleep state
 flagging

On 10/13/2015 11:57 PM, Bjorn Andersson wrote:
> The BIT() was incorrectly inherited from family A and should not be used
> on family B where the state is denoted by an enum.
> 
> Reported-by: Georgi Djakov <georgi.djakov@...aro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>

Tested-by: Georgi Djakov <georgi.djakov@...aro.org>

> ---
>  drivers/soc/qcom/smd-rpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c
> index b5feb58dbd9f..2969321e1b09 100644
> --- a/drivers/soc/qcom/smd-rpm.c
> +++ b/drivers/soc/qcom/smd-rpm.c
> @@ -126,7 +126,7 @@ int qcom_rpm_smd_write(struct qcom_smd_rpm *rpm,
>  	pkt->hdr.length = cpu_to_le32(sizeof(struct qcom_rpm_request) + count);
>  
>  	pkt->req.msg_id = cpu_to_le32(msg_id++);
> -	pkt->req.flags = cpu_to_le32(BIT(state));
> +	pkt->req.flags = cpu_to_le32(state);
>  	pkt->req.type = cpu_to_le32(type);
>  	pkt->req.id = cpu_to_le32(id);
>  	pkt->req.data_len = cpu_to_le32(count);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/