linux-kernel - Re: 4.3-rc3 BAR allocation problems on multiple machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.20.1510140816090.14105@math.ut.ee>
Date:	Wed, 14 Oct 2015 10:34:05 +0300 (EEST)
From:	Meelis Roos <mroos@...ux.ee>
To:	Yinghai Lu <yinghai@...nel.org>
cc:	Linux Kernel list <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: 4.3-rc3 BAR allocation problems on multiple machines

> > 0001:00:07.0 ISA bridge: ULi Electronics Inc. M1533/M1535/M1543 PCI to ISA Bridge [Aladdin IV/V/V+]
> >         Control: I/O+ Mem+ BusMaster+ SpecCycle+ MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
> >         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> >         Latency: 0
> >         Region 0: [virtual] I/O ports at 0000 [size=64K]
> >         Region 1: Memory at <unassigned> (32-bit, non-prefetchable) [size=1M]
> >         Region 2: Memory at <unassigned> (32-bit, non-prefetchable) [size=1M]
> >         Region 3: [virtual] Memory at fffff80100000000 (32-bit, non-prefetchable)
> >         Region 4: [virtual] Memory at fffff80100000000 (32-bit, non-prefetchable)
> >         Region 5: [virtual] Memory at fffff80100000000 (32-bit, non-prefetchable)
> >         [virtual] Expansion ROM at fffff80100000000 [disabled]
> >         Capabilities: [a0] Power Management version 1
> >                 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
> >                 Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
> > 00: b9 10 33 15 0f 00 10 02 00 00 01 06 00 00 00 00
> > 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > 20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > 30: 00 00 00 00 a0 00 00 00 00 00 00 00 00 00 00 00
> > 40: 03 13 4b 80 83 09 00 47 00 00 06 00 00 00 eb 31
> > 50: 00 00 00 20 90 02 20 03 66 03 00 00 00 00 00 08
> > 60: 40 00 00 00 00 00 00 00 00 00 00 00 80 20 00 00
> > 70: 00 00 0a 00 47 00 00 db 04 02 00 04 00 80 01 90
> > 80: a5 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > a0: 01 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00
> > b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 
> Please check attached patch.

Thank you, it seems to work. First, the following lines are gone:
PCI: Claiming 0001:00:07.0: Resource 0: 000007fe01000000..000007fe0100ffff [101]
PCI: Claiming 0001:00:07.0: Resource 1: 000007ff00000000..000007ff000fffff [200]
PCI: Claiming 0001:00:07.0: Resource 2: 000007ff00000000..000007ff000fffff [200]

And then all following PCI: Claiming... lines succeed, with no address 
conflicts.

Now, how can I be sure that removing the ULi ISA bridge allocations does 
not break anything? It seems I did not have I2C enabled in kernel conf - 
I emabled it now, recompiled, got this but it seems to be for another 
PCI device so not related?
ali15x3_smbus 0001:00:06.0: ALI15X3_smb region uninitialized - upgrade BIOS or use force_addr=0xaddr
ali15x3_smbus 0001:00:06.0: ALI15X3 not detected, module not inserted.

Additionally, another driver (i2c-ali1535) claimed 0001:00:06.0 and was 
happy but did not find anything (but I do not know what it sahould find 
so I can see no problem at the moment).

I also applied the patch on Sun Blade 100 where i2c was working for me. 
It was still working with this ali quirk patch applied, and no BAR 
errors.

What about other arches - does this patch affect other arches where the 
firmware has configured some addresses for this ULi bridge?

-- 
Meelis Roos (mroos@...ux.ee)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/