linux-kernel - Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 14 Oct 2015 11:56:59 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Michael Welling <mwelling@...e.org>
Cc:	Neil Armstrong <narmstrong@...libre.com>,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Fionn Cleary <clearyf@....ie>,
	Wolfram Sang <wsa@...-dreams.de>,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	Sebastian Reichel <sre@...nel.org>
Subject: Re: [RFC PATCH] spi: omap2-mcspi: disable other channels
 CHCONF_FORCE in prepare_message

On Fri, Oct 09, 2015 at 09:24:51AM -0500, Michael Welling wrote:
> On Fri, Oct 09, 2015 at 12:38:10PM +0100, Mark Brown wrote:
> > On Thu, Oct 08, 2015 at 10:21:05AM -0500, Michael Welling wrote:
> > > On Thu, Oct 08, 2015 at 04:45:00PM +0200, Neil Armstrong wrote:

> > > What is the point of doing this void cast below?
> > > Avoiding compiler warning perhaps?
> > > Perhaps you can __maybe_unused for the variable instead?

> > > > +	/* Ignore message */
> > > > +	(void)msg;

> > You shouldn't need it at all, but yes if there is a good reason to mark
> > something as unused the above annotation is better.

> Which one?

__maybe_unused.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)