linux-kernel - Re: [PATCH v2 1/2] Provide READ_ONCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151014134047.GA10316@gmail.com>
Date:	Wed, 14 Oct 2015 15:40:47 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Andrey Ryabinin <aryabinin@...tuozzo.com>
Cc:	kbuild test robot <lkp@...el.com>, kbuild-all@...org,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Lutomirski <luto@...capital.net>,
	Andrey Konovalov <andreyknvl@...gle.com>,
	Kostya Serebryany <kcc@...gle.com>,
	Alexander Potapenko <glider@...gle.com>,
	kasan-dev <kasan-dev@...glegroups.com>,
	Borislav Petkov <bp@...en8.de>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Dmitry Vyukov <dvyukov@...gle.com>,
	Sasha Levin <sasha.levin@...cle.com>,
	Wolfram Gloger <wmglo@...t.med.uni-muenchen.de>
Subject: Re: [PATCH v2 1/2] Provide READ_ONCE_NOCHECK()


* Andrey Ryabinin <aryabinin@...tuozzo.com> wrote:

> 
> 
> On 10/13/2015 07:02 PM, kbuild test robot wrote:
> > Hi Andrey,
> > 
> > [auto build test WARNING on tip/auto-latest -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Andrey-Ryabinin/Provide-READ_ONCE_NOCHECK/20151013-204127
> > config: mn10300-allyesconfig (attached as .config)
> > reproduce:
> >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=mn10300 
> > 
> > All warnings (new ones prefixed by >>):
> > 
> >    fs/nfs/filelayout/filelayout.c: In function 'filelayout_read_pagelist':
> >    fs/nfs/filelayout/filelayout.c:476:2: warning: format '%Zu' expects argument of type 'size_t', but argument 5 has type '__u32' [-Wformat=]
> >      dprintk("--> %s ino %lu pgbase %u req %Zu@...u\n",
> >      ^
> 
> So the actual warning is here. And it's not new.
> 
> >    In file included from include/linux/nfs_fs.h:28:0,
> >                     from fs/nfs/filelayout/filelayout.c:32:
> >    fs/nfs/filelayout/filelayout.c: In function 'filelayout_write_pagelist':
> >    include/linux/compiler.h:270:8: warning: format '%Zu' expects argument of type 'size_t', but argument 5 has type '__u32' [-Wformat=]
> >      union { typeof(x) __val; char __c[1]; } __u;  \
> >            ^
> >    include/linux/sunrpc/debug.h:33:24: note: in definition of macro 'dfprintk'
> >        printk(KERN_DEFAULT args); \
> >                            ^
> >>> include/linux/compiler.h:274:22: note: in expansion of macro '__READ_ONCE'
> >     #define READ_ONCE(x) __READ_ONCE(x, _check)
> >                          ^
> 
> And this 'note: in expansion of macro' belongs to the warning above.
> So it's a false-positive. 

So if this is a new warning introduced by these patches then the warning needs to 
be addresses - regardless of whether it's a false positive or not.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/