linux-kernel - Re: [PATCH] x86/amd_nb: Rename amd_get_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151014135104.GA8218@pd.tnic>
Date:	Wed, 14 Oct 2015 15:51:04 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>,
	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	dougthompson@...ssion.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org
Subject: Re: [PATCH] x86/amd_nb: Rename amd_get_node_id

On Wed, Oct 14, 2015 at 03:42:49PM +0200, Ingo Molnar wrote:
> 
> * Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com> wrote:
> 
> > This function doesn't give us the "Node ID" as the function
> > name suggests. Rather- it receives a PCI device as argument,
> > checks the available F3 PCI device IDs in the system
> > and returns the index of the matching Bus/Device IDs
> > 
> > Renaming it accordingly in this patch.
> > No functional change is introduced.
> > 
> > Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>
> > ---
> >  arch/x86/include/asm/amd_nb.h | 2 +-
> >  drivers/edac/amd64_edac.c     | 6 +++---
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/x86/include/asm/amd_nb.h b/arch/x86/include/asm/amd_nb.h
> > index 1a5da2e..319843d 100644
> > --- a/arch/x86/include/asm/amd_nb.h
> > +++ b/arch/x86/include/asm/amd_nb.h
> > @@ -81,7 +81,7 @@ static inline struct amd_northbridge *node_to_amd_nb(int node)
> >  	return (node < amd_northbridges.num) ? &amd_northbridges.nb[node] : NULL;
> >  }
> >  
> > -static inline u16 amd_get_node_id(struct pci_dev *pdev)
> > +static inline u16 amd_get_node_id_from_pci_dev(struct pci_dev *pdev)
> 
> So if we go to the trouble of naming things properly, I guess that function should 
> be named:
> 
> 	amd_pci_dev_to_node_id()
> 
> or so.

Or so.

This is in preparation for future changes anyway so the name had to
be not so generic and hint at the PCI dev argument. I'll change it to
amd_pci_dev_to_node_id() when applying.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/