linux-kernel - Re: [PATCH v3] iio: mma8452: support either of the available interrupt pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <561E70E0.1010508@metafoo.de>
Date:	Wed, 14 Oct 2015 17:12:32 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Martin Kepplinger <martink@...teo.de>, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	jic23@...nel.org, knaack.h@....de, pmeerw@...erw.net,
	mfuzzey@...keon.com
CC:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org,
	Martin Kepplinger <martin.kepplinger@...obroma-systems.com>
Subject: Re: [PATCH v3] iio: mma8452: support either of the available interrupt
 pins

On 10/14/2015 03:15 PM, Martin Kepplinger wrote:
[...]
> +			if (irq1 > 0)
> +				client->irq = irq1;

You must not overwrite client->irq, that field is manged by the I2C core and
is supposed to be read only for device drivers.

> +			dev_info(&client->dev, "using interrupt line INT1\n");

This should probably be a dev_dbg()

> +		} else {
> +			client->irq = irq2;
> +			dev_info(&client->dev, "using interrupt line INT2\n");

Same here

> +		}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/