linux-kernel - Re: [PATCH] staging: octeon: fixed few coding style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151014193419.GE7588@blackmetal.musicnaut.iki.fi>
Date:	Wed, 14 Oct 2015 22:34:19 +0300
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Sakshi Bansal <sakshi.april5@...il.com>
Cc:	gregkh@...uxfoundation.org, aaro.koskinen@...ia.com,
	ralf@...ux-mips.org, david.daney@...ium.com,
	paul.martin@...ethink.co.uk, aybuke.147@...il.com, arnd@...db.de,
	helen.fornazier@...il.com, joe@...ches.com,
	okash.khawaja@...il.com, janne.huttunen@...ia.com,
	jamie.lawler@...il.com, robertoxmed@...il.com, jtk54@...nell.edu,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: octeon: fixed few coding style warnings

Hi,

On Wed, Oct 14, 2015 at 07:36:37PM +0530, Sakshi Bansal wrote:
> Fixed allignment issues and line over 80 characters

You are also doing many other things which are not mention in the
commit log.

>  				/*
> -				  printk_ratelimited("Port %d received 0xd5 preamble\n",
> -					  port);
> +				 * printk_ratelimited("Port %d received 0xd5 preamble\n"
> +				 *		      port);
>  				 */

This is not really an improvement. Either the dead code should be deleted
altogether or converted to debug printk()s. (Probably the idea has been
that those printk()s can be "easily" enabled for debugging by removing
comment start/end marks.)

You also removed a comma there, breaking the syntax...

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/