linux-kernel - Re: [PATCH v2 for-next] EDAC: use edac_debugfs_remove_recursive instead of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151014194501.GF8218@pd.tnic>
Date:	Wed, 14 Oct 2015 21:45:01 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Tan Xiaojun <tanxiaojun@...wei.com>
Cc:	dougthompson@...ssion.com, mchehab@....samsung.com,
	wuyun.wu@...wei.com, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 for-next] EDAC: use edac_debugfs_remove_recursive
 instead of debugfs_remove

On Wed, Oct 14, 2015 at 09:49:24AM +0800, Tan Xiaojun wrote:
> debugfs_remove is used to remove a file or an empty directory from
> the debugfs filesystem, but mci->debugfs is not empty.
> 
> This is not easily discovered, because debugfs_remove return nothing
> when failed. It can be test like below:
> 
> 1)open EDAC config and open CONFIG_EDAC_DEBUG
> 2)insmod a edac_mc module (like i3000_edac or others in drivers/edac/)
> 3)rmmod this module
> 4)we can also see files under /sys/kernel/debug/edac/ like
>   "fake_inject"
> 
> Reported-by: Yun Wu (Abel) <wuyun.wu@...wei.com>
> Signed-off-by: Tan Xiaojun <tanxiaojun@...wei.com>

Applied,
thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/