linux-kernel - Re: [PATCH] crypto: x86: Remove duplicate define of SHA1_DIGEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1510142242030.3960@nanos>
Date:	Wed, 14 Oct 2015 22:44:39 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	LABBE Corentin <clabbe.montjoie@...il.com>
cc:	ameenali023@...il.com, bp@...en8.de, dan.carpenter@...cle.com,
	davem@...emloft.net, firogm@...il.com, herbert@...dor.apana.org.au,
	hpa@...or.com, mingo@...hat.com, minipli@...glemail.com,
	smueller@...onox.de, tim.c.chen@...ux.intel.com, x86@...nel.org,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: x86: Remove duplicate define of
 SHA1_DIGEST_SIZE

On Wed, 14 Oct 2015, LABBE Corentin wrote:

> The sha x86 crypto code use two define for the same thing:
> NUM_SHA1_DIGEST_WORDS and SHA1_DIGEST_LENGTH
> Replace them by SHA1_DIGEST_SIZE/4

That's wrong. Use only one for the number of words and make the define
so it's derived from the LENGTH.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/