linux-kernel - Re: [RFC PATCH] lightnvm: nvm_find_target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Oct 2015 22:55:02 +0200
From:	Matias Bjørling <m@...rling.me>
To:	kbuild test robot <lkp@...el.com>
Cc:	kbuild-all@...org, Christoph Hellwig <hch@...radead.org>,
	Jens Axboe <axboe@...com>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-nvme <linux-nvme@...ts.infradead.org>,
	Keith Busch <keith.busch@...el.com>,
	Javier Gonzalez <jg@...htnvm.io>,
	Stephen Bates <Stephen.Bates@...s.com>
Subject: Re: [RFC PATCH] lightnvm: nvm_find_target_type() can be static

On Wed, Oct 14, 2015 at 10:52 PM, kbuild test robot <lkp@...el.com> wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
>  core.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index 9b06d75..7205e57 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -34,7 +34,7 @@ static LIST_HEAD(nvm_mgrs);
>  static LIST_HEAD(nvm_devices);
>  static DECLARE_RWSEM(nvm_lock);
>
> -struct nvm_tgt_type *nvm_find_target_type(const char *name)
> +static struct nvm_tgt_type *nvm_find_target_type(const char *name)
>  {
>         struct nvm_tgt_type *tt;
>
> @@ -123,7 +123,7 @@ void nvm_unregister_mgr(struct nvmm_type *mt)
>  }
>  EXPORT_SYMBOL(nvm_unregister_mgr);
>
> -struct nvm_dev *nvm_find_nvm_dev(const char *name)
> +static struct nvm_dev *nvm_find_nvm_dev(const char *name)
>  {
>         struct nvm_dev *dev;
>
> @@ -209,7 +209,7 @@ static void nvm_free(struct nvm_dev *dev)
>         nvm_core_free(dev);
>  }
>
> -int nvm_validate_features(struct nvm_dev *dev)
> +static int nvm_validate_features(struct nvm_dev *dev)
>  {
>         struct nvm_get_features gf;
>         int ret;
> @@ -223,7 +223,7 @@ int nvm_validate_features(struct nvm_dev *dev)
>         return 0;
>  }
>
> -int nvm_validate_responsibility(struct nvm_dev *dev)
> +static int nvm_validate_responsibility(struct nvm_dev *dev)
>  {
>         if (!dev->ops->set_responsibility)
>                 return 0;
> @@ -231,7 +231,7 @@ int nvm_validate_responsibility(struct nvm_dev *dev)
>         return dev->ops->set_responsibility(dev->q, 0);
>  }
>
> -int nvm_init(struct nvm_dev *dev)
> +static int nvm_init(struct nvm_dev *dev)
>  {
>         struct nvmm_type *mt;
>         int ret = 0;
> @@ -304,7 +304,7 @@ err:
>         return ret;
>  }
>
> -void nvm_exit(struct nvm_dev *dev)
> +static void nvm_exit(struct nvm_dev *dev)
>  {
>         if (dev->ppalist_pool)
>                 dev->ops->destroy_dma_pool(dev->ppalist_pool);

Thanks! I'll apply it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/