linux-kernel - Re: [PATCH v2] usb: dwc2: host: Fix use after free w/ simultaneous irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=UExajBowJ9CRJEiutzSL5TaKdDFeuZJGcOrQsj6PAx8A@mail.gmail.com>
Date:	Thu, 15 Oct 2015 16:38:20 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	John Youn <John.Youn@...opsys.com>
Cc:	"balbi@...com" <balbi@...com>, Yunzhi Li <lyz@...k-chips.com>,
	Heiko Stübner <heiko@...ech.de>,
	"linux-rockchip@...ts.infradead.org" 
	<linux-rockchip@...ts.infradead.org>,
	Julius Werner <jwerner@...omium.org>,
	"gregory.herrero@...el.com" <gregory.herrero@...el.com>,
	"yousaf.kaukab@...el.com" <yousaf.kaukab@...el.com>,
	"dinguyen@...nsource.altera.com" <dinguyen@...nsource.altera.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] usb: dwc2: host: Fix use after free w/ simultaneous irqs

John,

On Thu, Oct 15, 2015 at 4:21 PM, John Youn <John.Youn@...opsys.com> wrote:
> Passing a NULL qtd to some of the subcases will lead to a NULL
> pointer dereference in that function or some function that it
> calls.
>
> I think you could just check the qtd after each call and bail if
> it's not ok.

I worry a little bit about ignoring an interrupt that we've already
acknowledged, but if you think that's safer I can certainly change the
patch.

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/