linux-kernel - Re: [PATCH v4 09/11] smack: namespace groundwork

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <01a101d1071c$8ce631b0$a6b29510$@alibaba-inc.com>
Date:	Thu, 15 Oct 2015 15:38:56 +0800
From:	"Hillf Danton" <hillf.zj@...baba-inc.com>
To:	"'Lukasz Pawelczyk'" <l.pawelczyk@...sung.com>
Cc:	"Andy Lutomirski" <luto@...capital.net>,
	"Kees Cook" <keescook@...omium.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	<linux-security-module@...r.kernel.org>
Subject: Re: [PATCH v4 09/11] smack: namespace groundwork

> 
> +static inline void smack_userns_free(struct user_namespace *ns)
> +{
> +	struct smack_ns *snsp = ns->security;
> +	struct smack_known *skp;
> +	struct smack_known_ns *sknp, *n;
> +
> +	list_for_each_entry_safe(sknp, n, &snsp->smk_mapped, smk_list_ns) {
> +		skp = sknp->smk_unmapped;
> +
> +		mutex_lock(&skp->smk_mapped_lock);
> +		list_del_rcu(&sknp->smk_list_known);
> +		if (sknp->smk_allocated)
> +			kfree(sknp->smk_mapped);
> +		kfree(sknp);

sknp is released,
> +		mutex_unlock(&skp->smk_mapped_lock);
> +
> +		list_del(&sknp->smk_list_ns);

but it is used again! typo?
> +	}
> +
> +	kfree(snsp);
> +}
> +
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/