lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1444873008-2589-1-git-send-email-shawn.lin@rock-chips.com> Date: Thu, 15 Oct 2015 09:36:48 +0800 From: Shawn Lin <shawn.lin@...k-chips.com> To: Vinod Koul <vinod.koul@...el.com>, Heiko Stuebner <heiko@...ech.de>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Mark Brown <broonie@...nel.org> Cc: Lars-Peter Clausen <lars@...afoo.de>, Doug Anderson <dianders@...omium.org>, Olof Johansson <olof@...om.net>, Sonny Rao <sonnyrao@...omium.org>, Addy Ke <addy.ke@...k-chips.com>, Boojin Kim <boojin.kim@...sung.com>, dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, alsa-devel@...a-project.org, linux-spi@...r.kernel.org, Yiwei Cai <cain.cai@...k-chips.com>, Shawn Lin <shawn.lin@...k-chips.com>, Jianqun Xu <xjq@...k-chips.com> Subject: [PATCH v6 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1 From: Yiwei Cai <cain.cai@...k-chips.com> Test with command - arecord -D hw:0,0 /tmp/a.wav, there are the error dump: dma-pl330 ffb20000.dma-controller: fill_queue:2251 Bad Desc(7) This error is happening when no a multiple of burst size * burst length are coming in. The root cause is pl330 dma controller on Rockchips' platform cannot support DMAFLUSHP instruction which make dma to flush the req of non-aligned or non-multiple of what we set before. The saftest way is to set dma max burst to 1. Signed-off-by: Yiwei Cai <cain.cai@...k-chips.com> Fixes: 4495c89fc ("ASoC: add driver for Rockchip RK3xxx I2S") Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com> cc: Addy Ke <addy.ke@...k-chips.com> cc: Jianqun Xu <xjq@...k-chips.com> cc: Heiko Stuebner <heiko@...ech.de> cc: Olof Johansson <olof@...om.net> cc: Doug Anderson <dianders@...omium.org> cc: Sonny Rao <sonnyrao@...omium.org> Acked-by: Mark Brown <broonie@...nel.org> --- Changes in v6: - remove quirks and get dma caps in order to limit burst Changes in v5: - use switch statement for dma_quirk's manipulation Changes in v4: None Changes in v3: None Changes in v2: None Changes in v1: None sound/soc/rockchip/rockchip_i2s.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index b936102..f00200a 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -418,6 +418,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) struct rk_i2s_dev *i2s; struct resource *res; void __iomem *regs; + struct dma_slave_caps *dma_caps; int ret; i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL); @@ -459,11 +460,24 @@ static int rockchip_i2s_probe(struct platform_device *pdev) i2s->playback_dma_data.addr = res->start + I2S_TXDR; i2s->playback_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; - i2s->playback_dma_data.maxburst = 4; i2s->capture_dma_data.addr = res->start + I2S_RXDR; i2s->capture_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; - i2s->capture_dma_data.maxburst = 4; + + if (snd_dmaengine_pcm_get_caps(&pdev->dev, &dma_caps) == 0) { + if (dma_caps.max_burst > 4) { + i2s->playback_dma_data.maxburst = 4; + i2s->capture_dma_data.maxburst = 4; + } else { + i2s->playback_dma_data.maxburst = 1; + i2s->capture_dma_data.maxburst = 1; + } + } else { + i2s->playback_dma_data.maxburst = 1; + i2s->capture_dma_data.maxburst = 1; + dev_info(&pdev->dev, + "Can't get dma caps, default limit maxburst to 1.\n"); + } i2s->dev = &pdev->dev; dev_set_drvdata(&pdev->dev, i2s); -- 2.3.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists