linux-kernel - Atmel sama5d3 boot regression, today's linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151015133015.GA28863@gradator.net>
Date:	Thu, 15 Oct 2015 15:30:16 +0200
From:	Sylvain Rochet <sylvain.rochet@...secur.com>
To:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Wenyou Yang <Wenyou.Yang@...el.com>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	Wonhong Kwon <wonhongkwon@...il.com>
Subject: Atmel sama5d3 boot regression, today's linux-next

Hi,

Atmel SAMA5D31 boards no longer boot on today's linux-next. Bisected to:

commit 7d24068e144adc03b805806645d732cf79488717
Author: Wonhong Kwon <wonhongkwon@...il.com>
Date:   Tue Oct 6 10:10:20 2015 +0900

    PM / hibernate: Move pm_init/pm_disk_init to late_initcall_sync

    pm_init is being invoked by core_initcall and hibernate_image_size_init
    calculates preferred image size (image_size) based on total pages
    (totalram_pages). This totalram_pages can be modified during various
    initcall-s phase and this can cause miscalculated image_size.

    For example, when CMA is being used, init_cma_reserved_pageblock tries
    to change the totalram_pages and this job is done during core_initcall.
    In order words, the totalram_pages doesn't take CMA reserved pages into
    account when image_size is calculated and it can be too small.

    Move pm_init and pm_disk_init to late_initcall_sync so that it happens
    after all other initcall-s change the totalram_pages.

    Reported-by: Sangseok Lee <sangseok.lee@....com>
    Signed-off-by: Wonhong Kwon <wonhong.kwon@....com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Reverting it fixes the issue.

Sylvain
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/