linux-kernel - Re: [PATCH 00/11] ARM: OMAP/DTS: dra7/72-evm/beagle-x15: Audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151015140959.GN10113@atomide.com>
Date:	Thu, 15 Oct 2015 07:09:59 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
	Tero Kristo <t-kristo@...com>
Subject: Re: [PATCH 00/11] ARM: OMAP/DTS: dra7/72-evm/beagle-x15: Audio
 support

* Peter Ujfalusi <peter.ujfalusi@...com> [151015 00:13]:
> Tony,
> 
> On 10/12/2015 11:57 PM, Tony Lindgren wrote:
> > * Tony Lindgren <tony@...mide.com> [150914 09:32]:
> >> * Peter Ujfalusi <peter.ujfalusi@...com> [150914 01:54]:
> >>> Hi Tony,
> >>>
> >>> On 08/24/2015 10:19 AM, Peter Ujfalusi wrote:
> >>>> Hi,
> >>>>
> >>>> this series will enable analog audio (via onboard aic310x codec) for dra7-evm,
> >>>> dra72-evm and am57xx-beagle-x15 boards.
> >>>> In these board McASP3 is connected to the codec and for the McASP3 we needed to
> >>>> have the DMA crossbar in place since the request lines are not mapped by
> >>>> default.
> >>>
> >>> Did you had a chance to look at this series?
> >>
> >> Looks OK to me, will look at it more once we have the fixes merged.
> >>
> >> Paul may have comments on the hwmod chage, looks like you forgot
> >> to Cc him on it. Can you please resend that one with Paul in Cc?
> > 
> > Applying all the dts changes into omap-for-v4.3/dt thanks. Paul
> > can pick up the hwmod change then after reviewing it.
> 
> Thanks for taking the DTS patches, however if Paul agrees with the way I think we can handle the McASP in DRA7xx then the patch which adds the mcasp3 node to dra7.dtsi needs to be replaced by:

Oh OK so the clocks may change. Well please send a follow up patch on
that then.

BTW, we should not set status = "disabled" in the SoC specific dtsi files.
The internal devices are there and we're better off having a struct device
created for them. If someobdy really wants to "disable" some internal device
for yet to be seen good reason, it should be done in the board specific dts
file.

Regards,

Tony

> From b6733f9ca96a997fab3d0455783e875dd9ae032b Mon Sep 17 00:00:00 2001
> From: Peter Ujfalusi <peter.ujfalusi@...com>
> Date: Tue, 24 Feb 2015 15:12:59 +0200
> Subject: [PATCH v2 03/12] ARM: DTS: dra7: Add McASP3 node
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
>  arch/arm/boot/dts/dra7.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 8fedddc35999..cde0a3cbf262 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1404,6 +1404,21 @@
>  			status = "disabled";
>  		};
>  
> +		mcasp3: mcasp@...68000 {
> +			compatible = "ti,dra7-mcasp-audio";
> +			ti,hwmods = "mcasp3";
> +			reg = <0x48468000 0x2000>;
> +			reg-names = "mpu";
> +			interrupts = <GIC_SPI 151 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "tx", "rx";
> +			dmas = <&sdma_xbar 133>, <&sdma_xbar 132>;
> +			dma-names = "tx", "rx";
> +			clocks = <&mcasp3_aux_gfclk_mux>, <&mcasp3_ahclkx_mux>;
> +			clock-names = "fck", "ahclkx";
> +			status = "disabled";
> +		};
> +
>  		crossbar_mpu: crossbar@...02a48 {
>  			compatible = "ti,irq-crossbar";
>  			reg = <0x4a002a48 0x130>;
> -- 
> 2.6.1
> 
> 
> 
> 
> -- 
> Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/