linux-kernel - Re: [PATCH] arm64: ftrace: function_graph: dump real return addr in call trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151015101812.7cb6e917@gandalf.local.home>
Date:	Thu, 15 Oct 2015 10:18:12 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Will Deacon <will.deacon@....com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	linux-arm-kernel@...ts.infradead.org,
	Li Bin <huawei.libin@...wei.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Christoffer Dall <christoffer.dall@...aro.org>,
	Punit Agrawal <punit.agrawal@....com>,
	Mark Rutland <mark.rutland@....com>, zhouchengming1@...wei.com,
	xiexiuqi@...wei.com, dingtianhong@...wei.com,
	linux-kernel@...r.kernel.org, guohanjun@...wei.com
Subject: Re: [PATCH] arm64: ftrace: function_graph: dump real return addr in
 call trace

On Thu, 15 Oct 2015 13:51:33 +0100
Will Deacon <will.deacon@....com> wrote:

> Is this the same old problem caused by e306dfd06fcb ("ARM64: unwind: Fix
> PC calculation")? I've said previously that I'm happy to revert that if
> we're the only architecture with this behaviour, but Akashi resisted
> because there are other issues with ftrace that he was hoping to address
> and they would resolve this too.

Just a reference, but this patch is pretty much exactly what x86
currently has. I wonder if I should make that function generic for all
archs to use.

If you accept this patch, I can look at what archs do and pull out the
common code and place it into the core code and have the archs call
that instead.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/