linux-kernel - Re: [PATCH] iommu/vt-d: Use cmpxchg16b to update posted format IRTE atomically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151015142420.GT27420@8bytes.org>
Date:	Thu, 15 Oct 2015 16:24:20 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	Feng Wu <feng.wu@...el.com>
Cc:	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/vt-d: Use cmpxchg16b to update posted format IRTE
 atomically

On Thu, Oct 15, 2015 at 10:19:11AM +0800, Feng Wu wrote:
> If IRTE is in posted format, the 'pda' field goes across the 64-bit
> boundary, we need use cmpxchg16b to atomically update it. We only
> expose posted-interrupt when X86_FEATURE_CX16 is supported and use
> to update it atomically.
> 
> Signed-off-by: Feng Wu <feng.wu@...el.com>
> ---
>  drivers/iommu/intel_irq_remapping.c | 33 ++++++++++++++++++++++++++++++---
>  1 file changed, 30 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> index f15692a..b4f7569 100644
> --- a/drivers/iommu/intel_irq_remapping.c
> +++ b/drivers/iommu/intel_irq_remapping.c
> @@ -169,8 +169,26 @@ static int modify_irte(struct irq_2_iommu *irq_iommu,
>  	index = irq_iommu->irte_index + irq_iommu->sub_handle;
>  	irte = &iommu->ir_table->base[index];
>  
> -	set_64bit(&irte->low, irte_modified->low);
> -	set_64bit(&irte->high, irte_modified->high);
> +#if defined(CONFIG_HAVE_CMPXCHG_DOUBLE)
> +	if ((irte->pst == 1) || (irte_modified->pst == 1)) {
> +		bool ret;
> +
> +		ret = cmpxchg_double(&irte->low, &irte->high,
> +				     irte->low, irte->high,
> +				     irte_modified->low, irte_modified->high);
> +		/*
> +		 * We use cmpxchg16 to atomically update the 128-bit IRTE,
> +		 * and it cannot be updated by the hardware or other processors
> +		 * behind us, so the return value of cmpxchg16 should be the
> +		 * same as the old value.
> +		 */
> +		BUG_ON(!ret);

Changed this to a WARN_ON, otherwise applied.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/