linux-kernel - Re: [PATCH] blk-mq: fix use-after-free in blk_mq_free_tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <561FBC6A.4040909@fb.com>
Date:	Thu, 15 Oct 2015 08:47:06 -0600
From:	Jens Axboe <axboe@...com>
To:	Junichi Nomura <j-nomura@...jp.nec.com>,
	Jens Axboe <axboe@...nel.dk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Keith Busch <keith.busch@...el.com>
Subject: Re: [PATCH] blk-mq: fix use-after-free in blk_mq_free_tag_set()

On 10/13/2015 11:02 PM, Junichi Nomura wrote:
> tags is freed in blk_mq_free_rq_map() and should not be used after that.
> The problem doesn't manifest if CONFIG_CPUMASK_OFFSTACK is false because
> free_cpumask_var() is nop.
> 
> tags->cpumask is allocated in blk_mq_init_tags() so it's natural to
> free cpumask in its counter part, blk_mq_free_tags().

Thanks, applied. tags->cpumask should some day die a horrible death.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/