linux-kernel - Re: [PATCH 0/5] x86/setup/crash: Cleanup some code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151015153351.GD8217@suse.de>
Date:	Thu, 15 Oct 2015 17:33:51 +0200
From:	Joerg Roedel <jroedel@...e.de>
To:	Borislav Petkov <bp@...en8.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Lutomirski <luto@...capital.net>,
	Dave Young <dyoung@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...nel.org>,
	jerry_hoemann@...com, Jiri Kosina <jkosina@...e.cz>,
	Juergen Gross <jgross@...e.com>,
	Mark Salter <msalter@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	WANG Chao <chaowang@...hat.com>, x86-ml <x86@...nel.org>
Subject: Re: [PATCH 0/5] x86/setup/crash: Cleanup some code

On Thu, Oct 15, 2015 at 10:20:26AM +0200, Borislav Petkov wrote:
> this is ontop of Baoquan's fix from yesterday:
> https://lkml.kernel.org/r/20151014104338.GA8235@pd.tnic
> 
> Looking at the crashkernel reservation code made a couple of style
> problems wink at me so this short cleanup should address them. Please
> take a look and complain if something's wrong.
> 
> Thanks.
> 
> Borislav Petkov (5):
>   x86/setup: Cleanup crashkernel reservation functions
>   x86/setup/crash: Remove alignment variable
>   x86/setup/crash: Cleanup some more
>   x86/setup/crash: Check memblock_reserve() retval
>   kexec/crash: Say which char is the unrecognized
> 
>  arch/x86/kernel/setup.c | 81 +++++++++++++++++++++++++------------------------
>  kernel/kexec_core.c     |  6 ++--
>  2 files changed, 45 insertions(+), 42 deletions(-)

Looks good to me.

Reviewed-by: Joerg Roedel <jroedel@...e.de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/